[mary-dev] Fwd: LsfFileHeader and MfccFileHeader

[Marc Schroeder]

sounds good to me.

Paulo Levi schrieb:
> 
> 
> ---------- Forwarded message ----------
> From: *Paulo Levi* <i30817 at gmail.com <mailto:i30817 at gmail.com>>
> Date: Tue, Mar 17, 2009 at 7:07 PM
> Subject: LsfFileHeader and MfccFileHeader
> To: mary-users <mary-users at dfki.de <mailto:mary-users at dfki.de>>
> 
> 
> I was looking at the useless casts and instanceof's in these header 
> objects, and found the readHeader override and the superclass 
> (FeatureFileHeader) readHeader doesn't do sanity checks. In on case it 
> ignores a null MaryRandomAccessFile argument and doesn't read the header 
> at all (LsfFileHeader). In the other two it throws a npe.
> Also the function takes a parameter to close the randomaccess file (but 
> doesnt close on exception).
> Should i introduce sanitychecks and refactor the methods to close even 
> if it throw a exception?
> 
> I'm going to commit the casts removal.
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Mary-dev mailing list
> Mary-dev at dfki.de
> http://www.dfki.de/mailman/cgi-bin/listinfo/mary-dev

-- 
Dr. Marc Schröder, Senior Researcher at DFKI GmbH
Coordinator EU FP7 Project SEMAINE http://www.semaine-project.eu
Portal Editor http://emotion-research.net
Team Leader DFKI Speech Group http://mary.dfki.de

Homepage: http://www.dfki.de/~schroed
Email: schroed at dfki.de
Phone: +49-681-302-5303
Postal address: DFKI GmbH, Campus D3_2, Stuhlsatzenhausweg 3, D-66123 
Saarbrücken, Germany
--
Official DFKI coordinates:
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Trippstadter Strasse 122, D-67663 Kaiserslautern, Germany
Geschaeftsfuehrung:
Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster (Vorsitzender)
Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313