[Rock-dev] Rock.cmake

[Sylvain Joyeux]

On 05/06/2011 06:02 PM, Alexander Duda wrote:
> On Fri, 2011-05-06 at 16:54 +0200, Sylvain Joyeux wrote:
>> On 05/06/2011 04:26 PM, Alexander Duda wrote:
>>> at the moment rock_vizkit_widget(target LIBS ...) is not linking the
>>> libraries and at least rock_widget_collection has undefined symbols
>> and
>>> will crash.
>> There is not LIBS options in the rock targets. There are only DEPS
>> and
>> DEPS_*
>
> There is an option LIBS but because of the internal renaming from
> ${TARGET_NAME}_LIBS to ${TARGET_NAME}_LIBRARIES some days ago the LIBS
> option is not working any more.
>
> To solve the problem we can rename the LIBS option to LIBRARIES.
I would keep the option as LIBS, and rename the variable as 
DEPENDENT_LIBRARIES

Otherwise, the generated variable name would be

   target_name_LIBRARIES

which is, in cmake, used to represent the libraries that should be 
linked to *use* target_name, not the libraries that should be linked to 
target_name.

... and I would document the LIBS option in the macro comments as it 
should have been done from the very beginning.
-- 
Sylvain Joyeux (Dr.Ing.)
Space & Security Robotics

!!! Achtung, neue Telefonnummer!!!

Standort Bremen:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Straße 5
28359 Bremen, Germany

Phone: +49 (0)421 178-454136
Fax:   +49 (0)421 218-454150
E-Mail: robotik at dfki.de

Weitere Informationen: http://www.dfki.de/robotik
-----------------------------------------------------------------------
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Firmensitz: Trippstadter Straße 122, D-67663 Kaiserslautern
Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster
(Vorsitzender) Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
USt-Id.Nr.:    DE 148646973
Steuernummer:  19/673/0060/3
-----------------------------------------------------------------------