[Rock-dev] Adding ExperimentMarker and ExperimentMarkerComment to Base?

[Matthias Goldhoorn]

On 31.08.2011 10:47, Alexander Duda wrote:
> On Wed, 2011-08-31 at 09:52 +0200, Sylvain Joyeux wrote:
>
>> On 08/31/2011 08:48 AM, Alexander Duda wrote:
>>> I think this is a really missing feature in rock replay. After looking
>>> into the implementation. I have the following remarks.
>>>
>>> * all functionality concerning the marker handling should go to the
>>> stream aligner (add_marker, next_marker, ...)
>>> * the marker streams should not be aligned with the other streams
>>> (discussible) instead the class Log::Replay should auto detect them by
>>> type and a user defined regular expression for the name and should add
>>> them to the stream aligner
>> A requirement of the marker stuff is that it should *not* rely on having
>> a pocolog stream for markers. Any list of markers "with the right
>> interface" should do. I.e. plain Ruby objects should work fine.
>> Moreover, we should be able to "merge" marker streams.
>> I agree, though, that Log::Replay should be able to look for a
>> corresponding pocolog stream and add it automatically.
>>
>> I don't understand: why, if you don't want to align the markers, you
>> would want the API to go on the stream aligner ? In my mind, markers are
>> just bookmarks, i.e. they allow to name a time. Then, you can tell the
>> system "go to XYZ" instead of "go to 14:03pm".
> +1 the StreamAligner should be independent of Marker streams.
> The idea of adding a generic bookmark handling to the stream aligner is
> that it could implement it in an efficient way (it knows about the
> internal structure of streams). If we can use the standard seek
> functionality. I agree we should put it into replay.
>
> StreamAligner:
> a = create_bookmark(time)
> seek(a)
>
> Alex
>
So overall result, should the functionality go to replay
tools/orocos.rb/lib/orocos/log/replay.rb
or
tools/pocolog/lib/pocolog/stream_aligner.rb

currently i put it to the replay..., the stream aligner is new in this 
discussion.

Matthias

-- 
  Dipl.-Inf. Matthias Goldhoorn
  Unterwasserrobotik

  Hauptanschrift Standort Bremen:
  DFKI GmbH
  Robotics Innovation Center
  Robert-Hooke-Straße 5
  28359 Bremen, Germany

  Phone: +49 (0)421 178 45-4193
  Fax:   +49 (0)421 178 45-4150
  E-Mail: robotik at dfki.de

  Weitere Informationen: http://www.dfki.de/robotik
  -----------------------------------------------------------------------
  Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
  Firmensitz: Trippstadter Straße 122, D-67663 Kaiserslautern
  Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster
  (Vorsitzender) Dr. Walter Olthoff
  Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
  Amtsgericht Kaiserslautern, HRB 2313
  Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
  USt-Id.Nr.:    DE 148646973
  Steuernummer:  19/673/0060/3