[Rock-dev] log file converter / updating frame.h SonarScan

[Sylvain Joyeux]

On 09/19/2011 08:10 PM, Alexander Duda wrote:
> Hi
>
> currently there is no generic way to update log files after a type was
> modified. Therefore I started to write a ruby library which supports the
> update process.
>
> To embed this library into rock I am planing to do the following:
>
> -->  create a new package tools/pos_proc.rb  (pos_proc = post processing)
I would have preferred log_tools. post_processing is way too "fill it 
with whatever". The .rb suffix should in general be used only when the 
package is a ruby-wrapper for another "thing" that already exists (i.e. 
orocos.rb to say "this is a Ruby interface for orocos")
> -->  add the converter library to pos_proc.rb (name space
> PosProc::LogFile::Converter
LogTools::Converter if log_tools is chosen
> -->  add the package to the package set rock.toolchain
>
> -->  add a script rock-convert to base/scripts/bin which can be used to
> update base types (rock-convert logfile.0.log)
Why not put it in log_tools/bin (or, following your proposal, 
post_proc.rb/bin) ???
> -->  add conversions rules for base
> to /base/orogen/types/lib/base/immigrate
Mmmmm .... I would rather have a src/log_migration.rb file and install 
it in share/rock/log/migration or something like that. In general, I 
start to dislike the Ruby code that stays in CMake packages. It should 
(in general) be installed with the rest of the package.

See e.g. corridor_planner/ruby/corridor_planner.rb
--

Sylvain Joyeux
Space&  Security Robotics

!!! Achtung, neue Telefonnummer!!!

Standort Bremen:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Straße 5
28359 Bremen, Germany

Phone: +49 (0)421 178-454136
Fax:   +49 (0)421 218-454150
E-Mail: robotik at dfki.de

Weitere Informationen: http://www.dfki.de/robotik
-----------------------------------------------------------------------
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Firmensitz: Trippstadter Straße 122, D-67663 Kaiserslautern
Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster
(Vorsitzender) Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
USt-Id.Nr.:    DE 148646973
Steuernummer:  19/673/0060/3
-----------------------------------------------------------------------