[Rock-dev] Namespace changed for base::odometry

[Jakob Schwendner]

On 04/02/2012 05:50 PM, Alexander Duda wrote:
> On Mon, 2012-04-02 at 17:21 +0200, Sylvain Joyeux wrote:
>> On 04/02/2012 05:08 PM, Alexander Duda wrote:
>>> On Mon, 2012-04-02 at 16:35 +0200, Malgorzata Goldhoorn wrote:
>>>> Hi all,
>>>>
>>>> I changed the namespace for the odometry package from base::odometry  to
>>>> odometry. You need to fix this in all your packages, which use this
>>>> base-type.
>>>> This change was already discussed with Sylvain.
>>> I think the mailing list would be a more convenient place to discuss
>>> things like this affecting quite a lot of components.
>>>
>>> Personally I am against changes like this before we release. We even
>>> opened a wiki page for this:
>>> http://rock.opendfki.de/wiki/WikiStart/OngoingWork/BaseTypesCleanup
>>>
>>> For all people using this type, this change also invalidates all old log
>>> files.
>> There are no oroGen types in the odometry namespace (and therefore no
>> need for convertions).
>>
>> However, you are absolutely right. I do apologize for having done that
>> change that close to the release. What I propose is that we don't remove
>> the classes from base/types (reverting the change), but introducing
>> slam/odometry as the "new" package and notifying that people should use
>> it instead of base/types for these purposes.
>>
>> Would that be OK for you ?
> I am not really effected by the change. Therefore the people who are
> using the type should decide if it is OK for them or not. I am fine with
> both solutions.
>
> I was only a bit surprised that changes like this are not discussed on
> the mailing list and that this change may lead to inconsistent on the
> web-page because we do not have a separation between master and next for
> the documentation so far or that people are complaining about
> rock-convert ;-).
>
> Alex
>
>
>
I think I might be the only one affected by it, and I'm ok (also 
discussed with Sylvain).

cheers,

Jakob