<div dir="ltr"><span style="font-family:arial,sans-serif;font-size:13.333333969116211px">Looking quickly at it, I think the patch goes in the right direction. However, I definitely **NOT** agree with the commit message. Now, if this throws a lot, it probably means that you have a serious problem with how your timestamper is configured (or, even worse, with your data acquisition).</span><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">
<br></div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">About the patch</div><div style="font-family:arial,sans-serif;font-size:13.333333969116211px">============<div>A possibly better patch would save the last returned period and return it instead of m_initial_period. (Not sure if it is really better, though)<br>
<div><br></div><div>About the message: Git commit messages are formatted with a single first line (the summary), a blank line and then the rest of the commit message. The summary should describe what is modified (not *why* it is modified). The why is better place in the bulk of the message, for instance:</div>
<div><br></div><div>timestamper: fix exception thrown when the time buffer gets empty while we actually have an initial period</div><div><br></div><div>The time buffer might get empty (we get this a lot with our ethernet hokuyo), in which case getPeriodInternal ends</div>
<div>up throwing an exception even though we do have a period estimate (the initial period).</div><div><br></div><div>About the timestamper configuration</div><div>============================</div><div>Why is the time buffer getting empty this often in your case ? It should definitely not !<br>
</div><div><br></div><div>Sylvain</div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Apr 15, 2014 at 11:54 AM, Raul Dominguez <span dir="ltr"><<a href="mailto:Raul.Dominguez@dfki.de" target="_blank">Raul.Dominguez@dfki.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Hello,<br>
<br>
An exception prompts quite often for our Hokuyo laser component
(controlled though ethernet).<br>
<br>
The exception comes from the Aggregator. I think that the attached
patch should help to avoid this.<br>
<br>
The solution is to return the initial period in <i>getPeriodInternal</i>
when the period is not computable from the last samples and is not
given. What do you think?<br>
<br>
<br>
Best regards,<br>
Raúl<br>
<br>
<br>
<br>
<pre cols="72">--
Raúl Domínguez (M.Sc.)
Space Robotics
Universität Bremen
FB 3 - Mathematik und Informatik
AG Robotik
Robert-Hooke-Straße 1
28359 Bremen, Germany
Zentrale: <a href="tel:%2B49%20421%20178%2045-6611" value="+49421178456611" target="_blank">+49 421 178 45-6611</a>
Besuchsadresse der Nebengeschäftstelle:
Robert-Hooke-Straße 5
28359 Bremen, Germany
Tel.: <a href="tel:%2B49%20421%20178%2045-6617" value="+49421178456617" target="_blank">+49 421 178 45-6617</a>
Empfang: <a href="tel:%2B49%20421%20178%2045-6600" value="+49421178456600" target="_blank">+49 421 178 45-6600</a>
Fax: <a href="tel:%2B49%20421%20178%2045-4150" value="+49421178454150" target="_blank">+49 421 178 45-4150</a>
E-Mail: <a href="mailto:Raul.Dominguez@uni-bremen.de" target="_blank">Raul.Dominguez@uni-bremen.de</a>
Weitere Informationen: <a href="http://www.informatik.uni-bremen.de/robotik" target="_blank">http://www.informatik.uni-bremen.de/robotik</a></pre>
</div>
<br>_______________________________________________<br>
Rock-dev mailing list<br>
<a href="mailto:Rock-dev@dfki.de">Rock-dev@dfki.de</a><br>
<a href="http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev" target="_blank">http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev</a><br>
<br></blockquote></div><br></div>