<div dir="ltr">It worked for me! </div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>--<br>Diego Brito dos Santos Cesar</div><div>+55 71 9267-8676</div></div></div></div></div></div>
<br><div class="gmail_quote">2016-06-21 22:12 GMT-03:00 Sylvain Joyeux <span dir="ltr"><<a href="mailto:bir.sylvain@gmail.com" target="_blank">bir.sylvain@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The main fixes are<br>
<br>
<a href="https://github.com/rock-core/base-logging/pull/1" rel="noreferrer" target="_blank">https://github.com/rock-core/base-logging/pull/1</a><br>
<a href="https://github.com/rock-core/base-console_bridge/pull/3" rel="noreferrer" target="_blank">https://github.com/rock-core/base-console_bridge/pull/3</a><br>
<br>
There are a bunch of other fixes. Some are already merged (in packages<br>
I maintain). Others have pending pull requests when I was using them.<br>
<br>
For those who wonder, when heavily header paths (and especially when<br>
its a package virtually used by everyone), the only valid test is a<br>
build in a clean bootstrap. Building in an existing bootstrap tests<br>
close to nothing.<br>
<span class="HOEnZb"><font color="#888888"><br>
Sylvain<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Tue, Jun 21, 2016 at 4:55 PM, Rafael Saback <<a href="mailto:rafaelsaback@gmail.com">rafaelsaback@gmail.com</a>> wrote:<br>
> Hey guys,<br>
><br>
> After the recent merges to rock, my bootstrap has started presenting some<br>
> linkage problems. All my packages that depend on iodrivers_base are<br>
> presenting this linkage problem, even though iodrivers_base itself does not<br>
> present it when I build the package. The backtrace of the error is shown<br>
> below:<br>
><br>
><br>
> Linking CXX executable usbl_evologics_bin<br>
> CMakeFiles/usbl_evologics_bin.dir/Main.cpp.o: In function `main':<br>
> /home/rafaelsaback/flatfish/bir_rock/drivers/usbl_evologics/src/Main.cpp:110:<br>
> undefined reference to `iodrivers_base::Driver::setReadTimeout(base::Time<br>
> const&)'<br>
> /home/rafaelsaback/flatfish/bir_rock/drivers/usbl_evologics/src/Main.cpp:113:<br>
> undefined reference to `iodrivers_base::Driver::openTCP(std::string const&,<br>
> int)'<br>
> /home/rafaelsaback/flatfish/bir_rock/drivers/usbl_evologics/src/Main.cpp:116:<br>
> undefined reference to `iodrivers_base::Driver::openSerial(std::string<br>
> const&, int)'<br>
> libusbl_evologics.so: undefined reference to<br>
> `iodrivers_base::Driver::readPacket(unsigned char*, int)'<br>
> libusbl_evologics.so: undefined reference to<br>
> `base::logging::Logger::log(base::logging::Priority, char const*, char<br>
> const*, int, char const*, char const*, ...) c$<br>
> libusbl_evologics.so: undefined reference to<br>
> `iodrivers_base::Driver::~Driver()'<br>
> libusbl_evologics.so: undefined reference to<br>
> `iodrivers_base::Driver::openURI(std::string const&)'<br>
> libusbl_evologics.so: undefined reference to<br>
> `base::logging::Logger::Logger()'<br>
> libusbl_evologics.so: undefined reference to `typeinfo for<br>
> iodrivers_base::Driver'<br>
> libusbl_evologics.so: undefined reference to<br>
> `iodrivers_base::Driver::close()'<br>
> libusbl_evologics.so: undefined reference to<br>
> `iodrivers_base::Driver::Driver(int, bool)'<br>
> libusbl_evologics.so: undefined reference to<br>
> `iodrivers_base::Driver::writePacket(unsigned char const*, int)'<br>
> collect2: error: ld returned 1 exit status<br>
><br>
><br>
> Best Regards,<br>
><br>
><br>
> --<br>
> Rafael Meireles Saback<br>
><br>
> On Mon, Jun 20, 2016 at 11:48 AM, Steffen Planthaber<br>
> <<a href="mailto:Steffen.Planthaber@dfki.de">Steffen.Planthaber@dfki.de</a>> wrote:<br>
>><br>
>> Hi,<br>
>><br>
>> It was not possible to also move base/spline out, because it uses<br>
>> base/Eigen.h which is defined in base/types (direct cyclic include). So<br>
>> the new library is now called base/logging, as only logging is included<br>
>> there (and Singleton.hpp which is used by the logging).<br>
>><br>
>> I left backward compability headers for logging in base/types.<br>
>><br>
>> As we currently also discuss whether base types should stay header only,<br>
>> I guess we can wait for that outcome until we decide on base/Spline.<br>
>><br>
>><br>
>> What's left is to do:<br>
>><br>
>> 1. transfer the ownership of <a href="https://github.com/planthaber/base-logging" rel="noreferrer" target="_blank">https://github.com/planthaber/base-logging</a><br>
>> to rock-core<br>
>><br>
>> 2. Merge <a href="https://github.com/rock-core/package_set/pull/79" rel="noreferrer" target="_blank">https://github.com/rock-core/package_set/pull/79</a> to define the<br>
>> base-logging package<br>
>><br>
>> Now the package is defined (no build impacting changed until now).<br>
>><br>
>> 3. Actually make base/types use the new library:<br>
>> <a href="https://github.com/rock-core/base-types/pull/80" rel="noreferrer" target="_blank">https://github.com/rock-core/base-types/pull/80</a><br>
>><br>
>> 4. make base/console_bridge dependent on base-logging instead of<br>
>> base/types<br>
>> <a href="https://github.com/rock-core/base-console_bridge/pull/2" rel="noreferrer" target="_blank">https://github.com/rock-core/base-console_bridge/pull/2</a><br>
>><br>
>><br>
>> Best, Steffen<br>
>><br>
>><br>
>><br>
>><br>
>> Am <a href="tel:30.05.2016" value="+5530052016">30.05.2016</a> um 14:48 schrieb Steffen Planthaber:<br>
>> > Hi,<br>
>> ><br>
>> > If nobody is against it, I'll prepare the according PRs as suggested in<br>
>> > the next days:<br>
>> ><br>
>> > 1. create a base-lib repo (request ownership transfer to rock-core)<br>
>> > 2. move all in base/src to base-lib/src (logging and spline support)<br>
>> > 3. remove from base/types repo<br>
>> > 4. adapt dependencies when needed (shouldn't be too much as base-lib<br>
>> > will keep it's name and .pc file).<br>
>> ><br>
>> > Best, Steffen<br>
>> ><br>
>> ><br>
>> > Am <a href="tel:30.05.2016" value="+5530052016">30.05.2016</a> um 13:42 schrieb Javier Hidalgo Carrió:<br>
>> >><br>
>> >><br>
>> >> On 25.05.2016 14:34, Steffen Planthaber wrote:<br>
>> >>> Hi,<br>
>> >>><br>
>> >>> I have an issue with a cyclic repo dependency with base/types because<br>
>> >>> it<br>
>> >>> also includes the logging headers.<br>
>> >>><br>
>> >>> I'd like to move these headers into another repository, if you agree.<br>
>> >> +1<br>
>> >>><br>
>> >>> I would name it "base-logging"<br>
>> >> Create a base-lib repository as Thomas suggested.<br>
>> >> I guess everything under base-types/src (including the logging) should<br>
>> >> be moved to base-lib.<br>
>> ><br>
>> ><br>
>> >><br>
>> >> Javier.<br>
>> >><br>
>> >> _______________________________________________<br>
>> >> Rock-dev mailing list<br>
>> >> <a href="mailto:Rock-dev@dfki.de">Rock-dev@dfki.de</a><br>
>> >> <a href="http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev" rel="noreferrer" target="_blank">http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev</a><br>
>> >><br>
>> ><br>
>> ><br>
>><br>
>><br>
>> --<br>
>> Steffen Planthaber<br>
>> Weltraumrobotik<br>
>><br>
>> Besuchsadresse der Nebengeschäftstelle:<br>
>> DFKI GmbH<br>
>> Robotics Innovation Center<br>
>> Robert-Hooke-Straße 5<br>
>> 28359 Bremen, Germany<br>
>><br>
>> Postadresse der Hauptgeschäftsstelle Standort Bremen:<br>
>> DFKI GmbH<br>
>> Robotics Innovation Center<br>
>> Robert-Hooke-Straße 1<br>
>> 28359 Bremen, Germany<br>
>><br>
>> Tel.: <a href="tel:%2B49%20421%20178%2045-4125" value="+49421178454125">+49 421 178 45-4125</a><br>
>> Zentrale: <a href="tel:%2B49%20421%20178%2045-0" value="+49421178450">+49 421 178 45-0</a><br>
>> Fax: <a href="tel:%2B49%20421%20178%2045-4150" value="+49421178454150">+49 421 178 45-4150</a> (Faxe bitte namentlich kennzeichnen)<br>
>> E-Mail: <a href="mailto:Steffen.Planthaber@dfki.de">Steffen.Planthaber@dfki.de</a><br>
>><br>
>> Weitere Informationen: <a href="http://www.dfki.de/robotik" rel="noreferrer" target="_blank">http://www.dfki.de/robotik</a><br>
>> -----------------------------------------------------------------------<br>
>> Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH<br>
>> Firmensitz: Trippstadter Straße 122, D-67663 Kaiserslautern<br>
>> Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster<br>
>> (Vorsitzender) Dr. Walter Olthoff<br>
>> Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes<br>
>> Amtsgericht Kaiserslautern, HRB 2313<br>
>> Sitz der Gesellschaft: Kaiserslautern (HRB 2313)<br>
>> USt-Id.Nr.: DE 148646973<br>
>> Steuernummer: 19/673/0060/3<br>
>> -----------------------------------------------------------------------<br>
>><br>
>> _______________________________________________<br>
>> Rock-dev mailing list<br>
>> <a href="mailto:Rock-dev@dfki.de">Rock-dev@dfki.de</a><br>
>> <a href="http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev" rel="noreferrer" target="_blank">http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> Rock-dev mailing list<br>
> <a href="mailto:Rock-dev@dfki.de">Rock-dev@dfki.de</a><br>
> <a href="http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev" rel="noreferrer" target="_blank">http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev</a><br>
><br>
_______________________________________________<br>
Rock-dev mailing list<br>
<a href="mailto:Rock-dev@dfki.de">Rock-dev@dfki.de</a><br>
<a href="http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev" rel="noreferrer" target="_blank">http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev</a><br>
</div></div></blockquote></div><br></div>