[mary-dev] Pitchmark correction in Mary 4.2

[Ingmar Steiner]

Dear Jerome,

from what I can tell, the corrPmDir property was disabled in the 
SnackPitchmarker five years ago, and in PraatPitchmarker, three years 
ago. See 
https://github.com/marytts/marytts/commit/dd3a345d2de6b788dc7e7484ef44a63720f5f2ca 
and 
https://github.com/marytts/marytts/commit/4611bf782aa940521f286e7660d20c32038da7bd
Note that the adjustPitchmarks and shiftTo* methods in 
PraatPitchmarker.java are dead code.

I've removed the reference to the legacy property in the Wiki at 
https://github.com/marytts/marytts/wiki/UnitSelectionVoiceCreation 
Thanks for pointing it out.

Best wishes,

-Ingmar

On 24/11/2012 22:10, Jerome Perri wrote:
> Hello!
>
> A question about Mary 4.2 (but I think it is the same in 4.3):
>
> I do not see in the code where the pitchmarks are corrected to zero
> crossing.
>
> In this document...
> http://mary.opendfki.de/wiki/VoiceImportComponents
> .... there is a mentioning of
> "corrPmDir - Output Dir Path for corrected pitch marks (Pitch marks
> tuned towards Zero Crossing)"
>
> But I can not select this property in the voice import tools.
>
> In the source code I also see some places where pitch correction would
> be done, for example
>
> private float[] adjustPitchmarks( String basename, float[] pitchmarks )
> throws IOException
>
> But this part of the code is never called, as far as I could tell.
>
> And my pitchmarks look indeed weird. I plotted a PM file in a wave
> editor, and they were not well placed.
> At least they don't seem to be at zero crossings.
> If somebody wants to have a look at the screenshot, please just tell me.
>
> Jerome

-- 
Ingmar Steiner
Postdoctoral Research Fellow
Centre for Next Generation Localisation

Multilingual Ubiquitous Speech Technology (MUSTER)
Computer Science and Informatics
University College Dublin

Speech Communication Laboratory
Centre for Language and Communication Studies
Trinity College Dublin