[Rock-dev] 3drov simulator repo in rock simulation - to remove

Sylvain Joyeux bir.sylvain at gmail.com
Fri Mar 27 15:58:48 CET 2015


On Fri, Mar 27, 2015 at 6:02 AM, Javier Hidalgo Carrió
<javier.hidalgo_carrio at dfki.de> wrote:
> My main idea for deleting it was because:
> 1. the rock-simulation group has a title which is: "MARS Simulation which is
> part of the rock-simulation toolkit"

This should be changed. rock-simulation is about simulation in Rock in
general, not only MARS.

> 2. 3dROV is not part of MARS (it's a substitution of it), therefore in my
> opinion it shouldn't be there
See point 1. above

> IMO I would delete it from rock-simulation. Where to put it is a different
> question but as I said I have it in my github account (the one in
> rock-simulation and the missing one). Therefore, those packages could be a
> good starting point in case ESA integrates 3dROV and rock in the future.
>
> https://github.com/jhidalgocarrio/simulation-orogen-highlevel_rpc_3drov
> https://github.com/jhidalgocarrio/simulation-orogen-lowlevel_rpc_3drov

Since you've been the one maintaining the packages, this should be
your call in the end. However, I would really urge you to leave the
code where it is, simply marking it as deprecated in the manifest.xml
(once we've agreed on the exact way), in the github descriptions and
finally in the README

Sylvain


More information about the Rock-dev mailing list