[Rock-dev] Adding ExperimentMarker and ExperimentMarkerComment to Base?

[Sylvain Joyeux]

On 08/31/2011 08:48 AM, Alexander Duda wrote:
> I think this is a really missing feature in rock replay. After looking
> into the implementation. I have the following remarks.
>
> * all functionality concerning the marker handling should go to the
> stream aligner (add_marker, next_marker, ...)
> * the marker streams should not be aligned with the other streams
> (discussible) instead the class Log::Replay should auto detect them by
> type and a user defined regular expression for the name and should add
> them to the stream aligner
A requirement of the marker stuff is that it should *not* rely on having 
a pocolog stream for markers. Any list of markers "with the right 
interface" should do. I.e. plain Ruby objects should work fine. 
Moreover, we should be able to "merge" marker streams.

I agree, though, that Log::Replay should be able to look for a 
corresponding pocolog stream and add it automatically.

I don't understand: why, if you don't want to align the markers, you 
would want the API to go on the stream aligner ? In my mind, markers are 
just bookmarks, i.e. they allow to name a time. Then, you can tell the 
system "go to XYZ" instead of "go to 14:03pm".
> * LogControl should have no functionality which is not related to the
> GUI (add_marker_stream_by_id)
+1
> * ruby is using a different naming scheme than c++. For example get_bla
> is written as bla
+1
> * get_stream_index_for_type is ambiguous because right now only the
> first found stream is returned which is matching the given type
+1. Should raise an exception if multiple streams exist with said type.

Also: use "nil" (lowercase), not NIL (uppercase)
> *please remove all debug outputs which cannot be turned off before
> committing
+1
> Furthermore I think we should also have the functionality in mind that
> the user wants to add markers during replay and wants to replay the
> streams from marker A to marker B only. Maybe we can also combine this
> functionality with the cutting lib/tool.
The markers should definitely be usable for cutting.

-- 
Sylvain Joyeux
Space&  Security Robotics

!!! Achtung, neue Telefonnummer!!!

Standort Bremen:
DFKI GmbH
Robotics Innovation Center
Robert-Hooke-Straße 5
28359 Bremen, Germany

Phone: +49 (0)421 178-454136
Fax:   +49 (0)421 218-454150
E-Mail: robotik at dfki.de

Weitere Informationen: http://www.dfki.de/robotik
-----------------------------------------------------------------------
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Firmensitz: Trippstadter Straße 122, D-67663 Kaiserslautern
Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster
(Vorsitzender) Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
USt-Id.Nr.:    DE 148646973
Steuernummer:  19/673/0060/3
-----------------------------------------------------------------------