[Rock-dev] Regarding dynamic properties

[Sylvain Joyeux]

On Friday, January 10, 2014 05:26:18 PM Matthias Goldhoorn wrote:
> Here is the updated patchset
> 
> another patch is on the RTT mailing list regard the blocking behaviour
Looks much better for me.

Minor comments:
 - I thought we would keep the setBlaBLa for the operation name, only the 
   "internal method" would be called __orogen_setBlaBla.
 - you do not need to include OperationCaller in TaskBase anymore
 - the yard return value specification was right for #setter_operation (you do 
   need the brackets)
 - the code for property and attributes is really really similar. Please 
   factor it into a separate method
 - you did not update the commit message
-- 
 Dr. Ing. Sylvain Joyeux
 Space and Security Robotics
 
 Besuchsadresse der Nebengeschäftstelle:
 DFKI GmbH
 Robotics Innovation Center
 Robert-Hooke-Straße 5
 28359 Bremen, Germany
 
 Postadresse der Hauptgeschäftsstelle Standort Bremen:
 DFKI GmbH
 Robotics Innovation Center
 Robert-Hooke-Straße 1
 28359 Bremen, Germany 

 Phone:     +49 421 178 45-4136
 Zentrale: +49 421 178 45-0
 Fax:           +49 421 178 45-4150 (Faxe bitte namentlich kennzeichnen)
 E-Mail:     sylvain.joyeux at dfki.de
 
 Weitere Informationen: http://www.dfki.de/robotik
 -----------------------------------------------------------------------
 Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
 Firmensitz: Trippstadter Straße 122, D-67663 Kaiserslautern
 Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster 
 (Vorsitzender) Dr. Walter Olthoff
 Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
 Amtsgericht Kaiserslautern, HRB 2313
 Sitz der Gesellschaft: Kaiserslautern (HRB 2313)
 USt-Id.Nr.:    DE 148646973
 Steuernummer:  19/673/0060/3 
 ---------------------------------------------------------------------