[Rock-dev] Regarding dynamic properties

[Matthias Goldhoorn]

On 13.01.2014 10:42, Sylvain Joyeux wrote:
> On Friday, January 10, 2014 05:26:18 PM Matthias Goldhoorn wrote:
>> Here is the updated patchset
>>
>> another patch is on the RTT mailing list regard the blocking behaviour
> Looks much better for me.
>
> Minor comments:
>   - I thought we would keep the setBlaBLa for the operation name, only the
>     "internal method" would be called __orogen_setBlaBla.
Why we still need the "old" operation?, i removed them to have not twice 
methods for the same.
The method setBlaBla is kept and called from the __orogen_ bla
>   - you do not need to include OperationCaller in TaskBase anymore
*done*
>   - the yard return value specification was right for #setter_operation (you do
>     need the brackets)
??? where what *confused*
>   - the code for property and attributes is really really similar. Please
>     factor it into a separate method
*done*
>   - you did not update the commit message
*done*

-- 
  Dipl.-Inf. Matthias Goldhoorn
  Space and Underwater Robotic

  Universität Bremen
  FB 3 - Mathematik und Informatik
  AG Robotik
  Robert-Hooke-Straße 1
  28359 Bremen, Germany
  
  Zentrale: +49 421 178 45-6611
  
  Besuchsadresse der Nebengeschäftstelle:
  Robert-Hooke-Straße 5
  28359 Bremen, Germany
  
  Tel.:    +49 421 178 45-4193
  Empfang: +49 421 178 45-6600
  Fax:     +49 421 178 45-4150
  E-Mail:matthias.goldhoorn at informatik.uni-bremen.de

  Weitere Informationen:http://www.informatik.uni-bremen.de/robotik

-------------- nächster Teil --------------
Ein Dateianhang mit Bin?rdaten wurde abgetrennt...
Dateiname   : 0001-Modified-handling-of-dynamic-properties.patch
Dateityp    : text/x-patch
Dateigr??e  : 0 bytes
Beschreibung: nicht verf?gbar
URL         : http://www.dfki.de/pipermail/rock-dev/attachments/20140113/85604734/attachment.bin