[Rock-dev] changed to double on base::JointState

Sylvain Joyeux sylvain.joyeux at dfki.de
Thu Aug 15 10:25:55 CEST 2013


On 08/15/2013 09:18 AM, Jakob Schwendner wrote:
> Hi,
>
> I just noticed a commit which changed all the types from float to double in
> base::JointState.
> I was just wondering why that is. A while ago we said that we use all
> doubles everywhere, but in light of ever growing log sizes at some point we
> said, the decision between float and double should be made on a case by case
> basis. Sylvain and I did some calculations and came to the conclusion the
> position field should be double to account for continous revolutions of e.g.
> wheels. The other fields should be fine with float... Was that change made
> to keep consistency within the type?
It was a misunderstanding between me and Leif ... Leif did a code review
and found quite a few bugs in the original implementation (thanks !)

Anyways, I've pushed a fixed version. Can some more eyeball pairs have a
close look at it ?

Sylvain


More information about the Rock-dev mailing list