[Rock-dev] Possible patch for the aggregator

[Sylvain Joyeux]

Looking quickly at it, I think the patch goes in the right direction.
However, I definitely **NOT** agree with the commit message. Now, if this
throws a lot, it probably means that you have a serious problem with how
your timestamper is configured (or, even worse, with your data acquisition).

About the patch
============
A possibly better patch would save the last returned period and return it
instead of m_initial_period. (Not sure if it is really better, though)

About the message: Git commit messages are formatted with a single first
line (the summary), a blank line and then the rest of the commit message.
The summary should describe what is modified (not *why* it is modified).
The why is better place in the bulk of the message, for instance:

timestamper: fix exception thrown when the time buffer gets empty while we
actually have an initial period

The time buffer might get empty (we get this a lot with our ethernet
hokuyo), in which case getPeriodInternal ends
up throwing an exception even though we do have a period estimate (the
initial period).

About the timestamper configuration
============================
Why is the time buffer getting empty this often in your case ? It should
definitely not !

Sylvain


On Tue, Apr 15, 2014 at 11:54 AM, Raul Dominguez <Raul.Dominguez at dfki.de>wrote:

>  Hello,
>
> An exception prompts quite often for our Hokuyo laser component
> (controlled though ethernet).
>
> The exception comes from the Aggregator. I think that the attached patch
> should help to avoid this.
>
> The solution is to return the initial period in *getPeriodInternal* when
> the period is not computable from the last samples and is not given. What
> do you think?
>
>
> Best regards,
> Raúl
>
>
>
> --
>  Raúl Domínguez (M.Sc.)
>  Space Robotics
>
>  Universität Bremen
>  FB 3 - Mathematik und Informatik
>  AG Robotik
>  Robert-Hooke-Straße 1
>  28359 Bremen, Germany
>
>  Zentrale: +49 421 178 45-6611
>
>  Besuchsadresse der Nebengeschäftstelle:
>  Robert-Hooke-Straße 5
>  28359 Bremen, Germany
>
>  Tel.:    +49 421 178 45-6617
>  Empfang: +49 421 178 45-6600
>  Fax:     +49 421 178 45-4150
>  E-Mail:  Raul.Dominguez at uni-bremen.de
>
>  Weitere Informationen: http://www.informatik.uni-bremen.de/robotik
>
>
> _______________________________________________
> Rock-dev mailing list
> Rock-dev at dfki.de
> http://www.dfki.de/mailman/cgi-bin/listinfo/rock-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.dfki.de/pipermail/rock-dev/attachments/20140415/121d0295/attachment.htm